-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update help text with suggestions from docs code review #2313
Merged
triarius
merged 5 commits into
main
from
pdp-1496-update-agent-help-with-feedback-from-docs-for-v3510
Aug 22, 2023
Merged
Update help text with suggestions from docs code review #2313
triarius
merged 5 commits into
main
from
pdp-1496-update-agent-help-with-feedback-from-docs-for-v3510
Aug 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
triarius
changed the title
Update help text with suggests from docs code review
Update help text with suggestions from docs code review
Aug 22, 2023
DrJosh9000
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅😅😅
@@ -11,7 +11,7 @@ import ( | |||
|
|||
const lockDoneHelpDescription = `Usage: | |||
|
|||
buildkite-agent lock release [key] | |||
buildkite-agent lock done [key] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅
@@ -26,7 +26,7 @@ Description: | |||
|
|||
Examples: | |||
|
|||
Unsetting the variables ′LLAMA′ and ′ALPACA′) | |||
Unsetting the variables ′LLAMA′ and ′ALPACA′: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅
triarius
deleted the
pdp-1496-update-agent-help-with-feedback-from-docs-for-v3510
branch
August 22, 2023 07:13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You may be wondering about the removal of line breaks from the code examples. This was done to reflected changes in the docs. It seems to still look good for the cli: