Artifact up/download to/from Azure Blob Storage #2318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
force-pushed
the
pdp-1504-artifacts-in-azure
branch
9 times, most recently
from
744fc46
to
85cd66f
Compare
DrJosh9000
force-pushed
the
pdp-1504-artifacts-in-azure
branch
3 times, most recently
from
260df95
to
d2fd7f9
Compare
DrJosh9000
changed the title
triarius
reviewed
Aug 28, 2023
| @@ -10,5 +12,5 @@ type Uploader interface { | |||
| URL(*api.Artifact) string | |||
|
|
|||
| // The actual uploading of the file | |||
| Upload(*api.Artifact) error | |||
| Upload(context.Context, *api.Artifact) error | |||
There was a problem hiding this comment.
Loving this internal package party we are having!
DrJosh9000
force-pushed
the
pdp-1504-artifacts-in-azure
branch
from
2d5202f
to
8479f91
Compare
DrJosh9000
changed the title
triarius
approved these changes
Aug 29, 2023
DrJosh9000
force-pushed
the
pdp-1504-artifacts-in-azure
branch
from
561fb77
to
22c2635
Compare
*_ACCESS_KEY is already redacted by default. *_CONNECTION_STRING is a reasonable addition, IMO.
DrJosh9000
force-pushed
the
pdp-1504-artifacts-in-azure
branch
from
22c2635
to
764384c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Azure Blob Storage as an accepted destination for artifacts.
To start with, it uses DefaultAzureCredential. This is fairly flexible, but unless the container is public, uploaded URLs cannot be accessed by default.
In the third commit I add support for account keys (shared key credentials), which can also be configured using a connection string. The shared key is mandatory for generating SAS (shared access signatures) URLs, which include a token allowing temporary access to a blob.