Increase timeouts #259
Merged
Increase timeouts #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@keithpitt given you chose the initial values, I'll need your eyes on this. I don't see many user-facing problems with the increases? |
|
Once this is merged I'll also backport to stable |
|
👍 |
If Buildkite Agent API is under load, we can end up with duplicate requests coming in if we don't respond within the timeout seconds. Increasing to 60 seconds should help slow down agents a little during load. Ideally we'd do exponential backoff or something similar.
toolmantim
force-pushed
the
increase-timeouts
branch
from
b105b59
to
28244c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases our HTTP response timeout to 1 minute, and decreases retry frequency for API calls from once every 1 second to once every 5 seconds.
This means the agent will now wait 10 seconds for a http connection, 60 seconds for a response, and then it'll wait 5 seconds before retrying. For network situations, or downtime, this means things will attempting to retry every 5 seconds instead of every second.