Set a user agent when downloading most artifacts #2671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This downloader tooling was using the default golang user agent which works fine, but it's nice to indicate to the servers what the client is with a little more detail. We already have a helper for generating a user agent string on API calls to Buildkite, so I've used it here too. This helper is used for artifatc downloads from: * S3 (AWS) * GCS (Google) * Artifactory It is not used for artifact downloads from Azure blob store. I'm only setting the user agent if none is provided to the downloader, but currently none of the places its used pass one in.
yob
force-pushed
the
downloader-useragent
branch
from
8f93ebc
to
b8ba274
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This downloader tooling was using the default golang user agent which works fine, but it's nice to indicate to the servers what the client is with a little more detail.
We already have a helper for generating a user agent string on API calls to Buildkite, so I've used it here too. This helper is used for artifatc downloads from:
It is not used for artifact downloads from Azure blob store.
I'm only setting the user agent if none is provided to the downloader, but currently none of the places its used pass one in.
Fixes PLT-2222
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)