Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache paths env var #2720

Merged
merged 3 commits into from Apr 9, 2024
Merged

Cache paths env var #2720

merged 3 commits into from Apr 9, 2024

Conversation

moskyb
Copy link
Contributor

@moskyb moskyb commented Apr 9, 2024

Description

Buildkite's upcoming hosted compute product will include a feature to mount cache volumes when instructed to do so by the buildkite backend. Though the mounting itself happens outside of the agent, the agent needs to tell the mounter where to mount the cache volumes.

This PR adds the ability for the agent to consume the cache paths from the accept job response, and pipes those paths through to an envar BUILDKITE_AGENT_CACHE_PATHS.

Context

COMP-321

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go fmt ./...)

Copy link
Contributor

@matthewborden matthewborden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to have a test to prevent regressions.

Looks good 👍🏻

@matthewborden matthewborden merged commit e18cd9d into main Apr 9, 2024
1 check passed
@matthewborden matthewborden deleted the cache-paths-env-var branch April 9, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants