Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment: override zero exit code on cancel #2741

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

DrJosh9000
Copy link
Contributor

Description

Fixes #1489

Changes

  • Add a new experiment, override-zero-exit-on-cancel
  • If the job is cancelled, and the exit status of the process is 0, override it to be 1 instead.

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go fmt ./...)

Copy link
Contributor

@moskyb moskyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🪟

@DrJosh9000 DrJosh9000 merged commit 3de030e into main Apr 23, 2024
1 check passed
@DrJosh9000 DrJosh9000 deleted the pdp-9-windows-exit-code-0 branch April 23, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cancelled jobs report an exit code of 0 on Windows
2 participants