-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make preferring runtime env default off #2747
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
requested changes
Apr 29, 2024
@@ -46,7 +47,7 @@ const ( | |||
var ( | |||
Available = map[string]struct{}{ | |||
AgentAPI: {}, | |||
DescendingSpawnPrioity: {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good find!
Co-authored-by: Josh <jd@buildkite.com>
DrJosh9000
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In v3.63.0 we made a breaking change to how pipelines were parsed, specifically the precedence of environment variables in a pipeline upload step.
This undoes that breaking change to restore the original behaviour (see buildkite/go-pipeline#35)
Changes
The following pipeline example exhibits the breaking change (Credit to @lizrabuya for the reproducible test case).
Pipeline Steps:
pipeline.yml:
Prior to agent version v3.63.0 this pipeline printed Checking fixed env values NEW-789 for both the first and second command jobs.
As of v3.63.0 and above the steps now prints NEW-123.
This restores the original behaviour.
This PR also adds an experiment flag
interpolation-prefers-runtime-env
which enables the behaviour introduced in v3.63.0.Testing
go test ./...
). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...
)