Replace calls to %v for error values in fmt.Errorf with %w #2763
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
%w
formatting verb has been available forever[citation needed] now, and it's frustrating to useerrors.Is
, expecting to find a wrapped error, only to find out that a call to%v
in afmt.Errorf
call (instead of%w
) has eaten all of the error decoration.This PR casts a wide brush across the codebase, and attempts to replace many (most? all?) uses of
%v
for errors in calls tofmt.Errorf
with%w
, properly wrapping those errorsTesting
go test ./...
). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...
)