Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive "Dont sign initial steps with interpolations" #2813

Conversation

zhming0
Copy link
Contributor

@zhming0 zhming0 commented Jun 6, 2024

Reverts #2812

This is reviving a reverted PR #2807.

In addition to the original change, this PR upgrades the version of buildkite/interpolate to avoid the bug mentioned in the revert PR #2812.

@zhming0 zhming0 requested review from moskyb and DrJosh9000 June 6, 2024 01:30
@zhming0 zhming0 marked this pull request as ready for review June 6, 2024 01:30
Copy link
Contributor

@moskyb moskyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! do you mind squashing the go mod tidy commit onto the upgrade commit prior to merge?

@zhming0
Copy link
Contributor Author

zhming0 commented Jun 6, 2024

LGTM! do you mind squashing the go mod tidy commit onto the upgrade commit prior to merge?

yep I will squash them all into one.

@zhming0 zhming0 merged commit 5be2871 into main Jun 6, 2024
1 check passed
@zhming0 zhming0 deleted the revert-2812-revert-2807-dont-sign-initial-steps-with-interpolations branch June 6, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants