Publish debian and rpm packages to Buildkite Packages #2824
Conversation
| queue: "deploy" | ||
| plugins: | ||
| - docker#v5.8.0: | ||
| image: "public.ecr.aws/docker/library/ruby:3.0" |
There was a problem hiding this comment.
afaict we aren't actually using ruby at all - can we make this alpine or debian:$WHATEVER_DEBIAN_VERSION_PEOPLE_LIKE_USING_THESE_DAYS or something?
There was a problem hiding this comment.
Yup, happy to use whatever. I was using the same image so that it might already be warm in the cache, and it has curl installed. Neither alpine nor debian have curl installed.
032379705303.dkr.ecr.us-east-1.amazonaws.com/deploytools:2022.07 seems to be used by other steps and has curl, I'll swap to that.
There was a problem hiding this comment.
Worth nothing, what these script are currently doing should be folded into bk or a plugin or something over time, hopefully without needing docker involved at all.
There was a problem hiding this comment.
cool, looking forward to it!
There was a problem hiding this comment.
these two files (publish-debian-buildkite-packages.sh and publish-rpm-buildkite-packages.sh) seem to have almost the same functionality - are you able to combine them into one and parameterise them?
|
Cheers for the feedback @moskyb. |
|
Looks like the deploy tools container is unhappy with me, not sure why yet 
https://buildkite.com/buildkite/agent-release-edge/builds/1275#01900ad3-e46c-4f19-8301-8b9f8f62f0c5 |
|
(I was using the wrong queue!) |
|
@sj26 buildkite/agent isn't on the allowlist for the deploy queue any more - hopefully |
|
@yob yeah thanks, I think I originally copy/pasted the Packagecloud steps from an older branch which was still using the deploy queue — PEBKAC. |
|
change change, everywhere, 🧀 |
We've added support for OIDC tokens to the package create endpoint built into Buildkite Packages now, so let's try it out! This adds another step similar to the Packagecloud task which uses an OIDC token to upload the agent packages to Buildkite Packages.
Testing this is a little tricky. I think we kinda just need to try it. All the changes are isolated to steps which are allowed to soft fail. The scripts are mostly copy/pasted from the proven Packagecloud scripts and then the differences I've tested in my terminal (e.g. https://github.com/buildkite/buildkite/pull/17083#issuecomment-2161873567).
Fixes PKG-7120.