Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish Buildkite Packages — Fix Urls #2833

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Publish Buildkite Packages — Fix Urls #2833

merged 3 commits into from
Jun 13, 2024

Commits on Jun 13, 2024

  1. Fix log group name

    @sj26
    sj26 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    678217b View commit details
    Browse the repository at this point in the history

  2. Fix slug splitting 

    The glob was the wrong way around 🤦

Given:

   REGISTRY="acme-inc/widgets"

Before:

   ORGANIZATION_SLUG="${REGISTRY%*/}"
   # => ORGANIZATION_SLUG=acme-inc/widgets

After:

   ORGANIZATION_SLUG="${REGISTRY%/*}"
   # => ORGANIZATION_SLUG=acme-inc
    @sj26
    sj26 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    0e1c139 View commit details
    Browse the repository at this point in the history

  3. Make sure HTTP failures will fail the script/step

    @sj26
    sj26 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    f655b8e View commit details
    Browse the repository at this point in the history