Fix Content-Type for Google Cloud Storage API calls #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add github.com/golang/protobuf
* Bump golang.org/x/{net,oauth2}
* Add google.golang.org/grpc
* Bump google.golang.org/{api,cloud}
The Google Cloud Storage team now recommends using
Media(file, googleapi.ContentType(""))
to bypass auto-sniffing. See googleapis/google-api-go-client#134 for
background.
|
Nice! Thanks for fixing this for us! I'll merge it in now. Are you using the 3.0 beta series to 2.1.x? |
|
Thanks! We're now using the latest master (3.0 beta series). |
|
@grosskur cool cool, I just pushed out a new beta with your changes: https://github.com/buildkite/agent/releases/tag/v3.0-beta.7 Let me know if it's all good now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Google Cloud Storage team rolled out a change today to their service that checks the Content-Type header more strictly against the GS object metadata. Previously, the Buildkite agent would use the Google API library in the normal way, which would allow GS to sniff the content type and fill in the metadata header. But since we also set the Content-Type header when uploading, this unfortunately results in errors like:
The Google Cloud Storage team recommends fixing this by updating to the latest Google API client library and disabling Content-Type auto-sniffing with:
See googleapis/google-api-go-client#134 for background.