Fix parsing of git urls with windows volumes in them

[lox]

This change handles parsing urls like file:///C:/Users/vagrant/repo.

[lox]

This was a particularly gross usage of table tests. I think the result post discussion in #630 tells a much better story. Feels @keithpitt?

[keithpitt]

Should this be...

 assert.Nil(err)

..instead?

[keithpitt]

I also learnt about this syntax:

func TestSomething(t *testing.T) {
  assert := assert.New(t)

  assert.Nil(err)
}

So you don't need to pass t around everywhere.

[lox]

The problem with that is that assert.Nil isn't actually fatal, it doesn't stop the test. I tend to think the if block with a Fail is a lot clearer here. Go's error handling is meant to look like this :)

[lox]

The alternative would be:

if !assert.NoError(err) {
  t.FailNow()
}

Which is ok I guess? Doesn't seem worth the cognitive overhead.

[keithpitt]

Orrr....

import (
  "github.com/stretchr/testify/require"
)

func TestSomething(t *testing.T) {
  require := require.New(t)

  require.Nil(err)
}

That'll blow up the test (instead of running) if it fails! Maybe better/worse?

[keithpitt]

(See: https://godoc.org/github.com/stretchr/testify/require)

[lox]

It makes me sad :(

[lox]

Reckon I'm going to stick with this as is rather than bring in a whole new package.

[keithpitt]

Can you just use require instead of assert for the whole thing?

[lox]

Yup, we could. I guess if we are doing the whole testify thing we might as well bring it all in.