Try to help people that forget to quote their upload globs #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lox
approved these changes
Apr 23, 2018
|
Yay, thanks @lox! 🙌🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did this in a script, to upload some JUnit xml files:
buildkite-agent artifact upload *.xmland it failed with this error message:
This had me very confused for a few hours, until I realised that there was a second argument to upload called "upload destination" — I had assumed that the error message on upload destination was that I had misconfigured my agent, or it was a backend problem.
What I needed to do was:
buildkite-agent artifact upload "*.xml"This PR tries to provide a less confusing error message if people accidentally provide a second argument to the
artifact uploadcommand.