Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ubuntu docker image #749

Merged
merged 11 commits into from May 1, 2018
Merged

Add ubuntu docker image #749

merged 11 commits into from May 1, 2018

Conversation

lox
Copy link
Contributor

@lox lox commented Apr 29, 2018

We still refer to an ubuntu docker image in https://buildkite.com/docs/agent/v3/docker. I think it makes sense to offer an ubuntu variant as well as alpine.

This will have a -ubuntu suffix, so buildkite/agent:3.0-ubuntu and will use the latest LTS.

@lox lox force-pushed the add-ubuntu-docker-image-variant branch from ad1ee6d to 836198d Compare April 29, 2018 22:30
@toolmantim
Copy link
Contributor

We deprecated the Ubuntu image quite a while ago… we just forgot to update the docs. I wonder if it's a good idea to bring it back? Then we'd add jessie too I guess? We initially deprecated it to reduce the support footprint.

We could instead have some instructions for building your own Ubuntu + Jessie images?

@lox
Copy link
Contributor Author

lox commented Apr 30, 2018

It seems like it's pretty standard to have a default alpine build but also an ubuntu or debian build for things @toolmantim. I'm ok with adding it to the build process, enough people have asked and the size of the ubuntu image has come right down over time. Feels?

@lox lox force-pushed the add-ubuntu-docker-image-variant branch from 1c8cb32 to 1fd565c Compare April 30, 2018 01:51
@toolmantim
Copy link
Contributor

Cool cool, sounds worth it?

The only other thing maybe to consider is keeping our OS base up-to-date with security vulns too? Alpine base tends to have much less vulns, and at the moment we only update our images on agent release at the moment.

https://hub.docker.com/r/buildkite/agent/tags/

@toolmantim
Copy link
Contributor

How do other people handle that I wonder? With Docker Hub auto-build you can have it trigger based on other dependent images. We could use a daily scheduled build? So package updates would be picked up max 24h after the OS packages are updated.

@lox
Copy link
Contributor Author

lox commented Apr 30, 2018

Yeah, it's a tricky problem. We basically need to monitor upstream images somehow and trigger agent builds, but we also need a way to notify us so we can cut new releases.

@lox lox merged commit 03ad265 into master May 1, 2018
@lox lox deleted the add-ubuntu-docker-image-variant branch May 1, 2018 01:31
@harrietgrace
Copy link
Contributor

Sweet! @lox, so in the docs, should the command be:

docker run -e BUILDKITE_AGENT_TOKEN="INSERT-YOUR-AGENT-TOKEN-HERE" buildkite/agent:3.0-ubuntu

Does that mean the alpine one should have the buildkite/agent:3.0 bit at the end too, instead of just buildkite/agent?

@lox
Copy link
Contributor Author

lox commented May 2, 2018

I might make buildkite/agent:ubuntu work @harrietgrace!

@harrietgrace
Copy link
Contributor

That would be rad 🙏🏻 Thanks!

@lox
Copy link
Contributor Author

lox commented May 2, 2018

The alpine one doesn't have a suffix, so buildkite/agent:3.0, buildkite/agent:3 or buildkite/agent:latest would all refer to the alpine image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants