New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ubuntu docker image #749
Conversation
ad1ee6d
to
836198d
Compare
We deprecated the Ubuntu image quite a while ago… we just forgot to update the docs. I wonder if it's a good idea to bring it back? Then we'd add jessie too I guess? We initially deprecated it to reduce the support footprint. We could instead have some instructions for building your own Ubuntu + Jessie images? |
It seems like it's pretty standard to have a default alpine build but also an ubuntu or debian build for things @toolmantim. I'm ok with adding it to the build process, enough people have asked and the size of the ubuntu image has come right down over time. Feels? |
1c8cb32
to
1fd565c
Compare
Cool cool, sounds worth it? The only other thing maybe to consider is keeping our OS base up-to-date with security vulns too? Alpine base tends to have much less vulns, and at the moment we only update our images on agent release at the moment. |
How do other people handle that I wonder? With Docker Hub auto-build you can have it trigger based on other dependent images. We could use a daily scheduled build? So package updates would be picked up max 24h after the OS packages are updated. |
Yeah, it's a tricky problem. We basically need to monitor upstream images somehow and trigger agent builds, but we also need a way to notify us so we can cut new releases. |
Sweet! @lox, so in the docs, should the command be:
Does that mean the alpine one should have the |
I might make |
That would be rad 🙏🏻 Thanks! |
The alpine one doesn't have a suffix, so |
We still refer to an ubuntu docker image in https://buildkite.com/docs/agent/v3/docker. I think it makes sense to offer an ubuntu variant as well as alpine.
This will have a
-ubuntu
suffix, sobuildkite/agent:3.0-ubuntu
and will use the latest LTS.