Allow --no-plugins=false to force plugins on #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default plugins are disabled when no-command-eval or no-local-hooks is set. This allows a way around that.
|
👍🏼 Noice! Sounds sensible, given the way the args are set up. |
|
Thanks for implementing this @lox, much appreciated! |
keithpitt
approved these changes
Jul 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default plugins are disabled when no-command-eval or no-local-hooks is set. This allows a way around that.
I kind of hate the syntax of
--no-plugins=true, and I hate even more the ternary nature of this, in that we only look at thefalsevalue if it's specifically set vs just the default value. Suggestions welcomed.