New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plugin locking before checkout #827

Merged

lox merged 1 commit into master from add-plugin-locking-before-directory-creation

Oct 7, 2018

Contributor

lox commented Oct 5, 2018

A race condition was reported in #763 where the concurrency lock for plugin checkout is only created after the plugin directory is created.

This moves the lock earlier, which should prevent the problem.


          Move plugin lock to before mkdir

9d82158

lox requested a review from a team

October 5, 2018 04:04

Contributor Author

lox commented Oct 7, 2018

Pretty sure this solves the issue, so going to sneaky merge.

lox merged commit 1d417e3 into master

lox deleted the add-plugin-locking-before-directory-creation branch

October 7, 2018 22:42

lox mentioned this pull request

Ensure plugin directory exists, otherwise checkout lock thrashes #828

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment