Use transparent golang http2 transport #849
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using a very old version of
golang.org/x/net/http2
(circa 2017), as well as configuring http2 support manually. In golang 1.6 and later this is done transparently.I also noticed that we used the deprecated
Transport.Dial
vsTransport.DialContext
, which needed to be updated before transparent http2 detection was done.You can see
http2
logging withGODEBUG=http2debug=2 go run *.go start --debug