Change git-clean-flags to cleanup submodules #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out that a second -f is needed to force git clean to remove .git subdirectories.
toolmantim
approved these changes
Dec 16, 2018
There was a problem hiding this comment.
Yeah, I agree that it's definitely how we thought it worked, and it's a bug fix for submodules.
I guess some people might have noticed they could put a git directory into a build directory some other way, and it wouldn't be cleaned up? But not having the extra f is going to trip people up, that had no idea. So I reckon let鈥檚 just ship it in a minor release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that a second -f is needed to force
git cleanto remove .git subdirectories.From https://git-scm.com/docs/git-clean:
The big question here is whether this counts as a breaking change 馃 I am leaning towards no, as I think we thought that this was the behaviour of the existing flags, so I view this as fixing a bug.
Closes #865.