Give all the things a logger instance #880
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the rise of our new
--spawn
param, I'd really like to have a prefix in the log output for the specific agent that console output is coming from. This is really, really hard to do with the global logger.This moves to an instance that gets passed into anything that needs a logger. It's a lot of code and opens up a lot of spots for nil pointer errors as we rarely use constructors and tend to use direct struct instantiations.
I'd love some feels on this approach. It's been hard work and I don't super like the result, but it's probably more correct?