New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests exposing a paths issue. #881
Conversation
On windows, absolute paths start either with \ or with c: (as in, drive-letter then colon)
@@ -3,7 +3,7 @@ | |||
We frequently introduce new experimental features to the agent. You can use the `--experiment` flag to opt-in to them and test them out: | |||
|
|||
```bash | |||
buildkite-agent start --experiment experiment1 --experiment expertiment2 | |||
buildkite-agent start --experiment experiment1 --experiment experiment2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅
Thanks @petemounce, we've still got a lot of little quirks to work out with windows paths. Assuming this test will fail? |
@lox yes - https://forum.buildkite.community/t/bug-config-on-windows-doesnt-do-what-i-thought/182/3 Sorry, should have replicated that post here. I run the agent with NSSM, configured like:
I see a fatal error in the log file:
|
Works around buildkite-agent absolute path problem - doesn't understand drive-rooted paths on windows. See also buildkite/agent#881. Makes the start parameters configurable. Also delete the configuration file from the zip file, because the agent prefers to find its configuration next-door to the binary ahead of any of the search paths, and if the stub is in place it'll use that in preference to our rendered version.
I'm going to merge this and then fix it, thanks @petemounce. |
On windows, absolute paths start either with \ or with c: (as in, drive-letter then colon)