Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition between stop/cancel and register #971

Merged
merged 1 commit into from Apr 2, 2019
Merged

Fix race condition between stop/cancel and register #971

merged 1 commit into from Apr 2, 2019

Conversation

lox
Copy link
Contributor

@lox lox commented Apr 1, 2019

I discovered a race condition where ctrl-c wouldn't stop the agent if pressed exactly at the right time (just after registration, but before pings start).

@lox lox merged commit 74afce3 into master Apr 2, 2019
@lox lox deleted the fix-race-condition-in-agent-shutdown-after-register branch April 2, 2019 04:31
@stevenmatthewt stevenmatthewt mentioned this pull request Apr 19, 2019
Closed
lox added a commit that referenced this pull request Apr 19, 2019
@lox
Ensure heartbeats run until agent is stopped
652fa78 
Fixes a regression in #971
@lox lox mentioned this pull request Apr 19, 2019
Merged
lox added a commit that referenced this pull request Apr 20, 2019
@lox
Ensure heartbeats run until agent is stopped
1133d33 
Fixes a regression in #971
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@lox