This repository has been archived by the owner on Sep 10, 2021. It is now read-only.
Fixed libxss issue for non-updated puppeteer #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x80486
reviewed
Feb 18, 2021
Dockerfile
Outdated
| @@ -6,7 +6,7 @@ | |||
| FROM node:12.18.3-buster-slim@sha256:dd6aa3ed10af4374b88f8a6624aeee7522772bb08e8dd5e917ff729d1d3c3a4f | |||
|
|
|||
| RUN apt-get update \ | |||
| && apt-get install -y wget gnupg ca-certificates \ | |||
| && apt-get install -y wget gnupg ca-certificates libxss1 \ | |||
There was a problem hiding this comment.
I think this is still relevant even with Node.js 14.x, but you might want to rebase (now that version 14.x made it into master) and check again.
There was a problem hiding this comment.
Yeah our builds have been failing since the update to 14.x
There was a problem hiding this comment.
Then I think you might want to merge this one 😅
|
Not trying to rush this but we'd love to get this merged as it is also causing issues with our builds 😢 Looks like an earlier PR (#135) was closed, a workaround (besides creating a separate |
|
Hey all, sorry this took so long. Thanks for the PR @kami4ka 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue when the stable version of Chrome doesn't cover all Puppeteer dependencies