Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directions for parallel builds is not accurate for upstart systems #186

Closed
jbeker opened this issue Feb 16, 2018 · 4 comments
Closed

Directions for parallel builds is not accurate for upstart systems #186

jbeker opened this issue Feb 16, 2018 · 4 comments

Comments

@jbeker
Copy link

jbeker commented Feb 16, 2018

The directions here https://buildkite.com/docs/builds/parallel-builds where it talks about running multiple agents is not accurate for newer Ubuntu systems that use systemd based configurations.

Are there updates or other documentation available?

@lox
Copy link
Contributor

lox commented Feb 16, 2018

The correct way to do this is with systemd template files: https://fedoramagazine.org/systemd-template-unit-files/

We'll look at getting some docs for this and also perhaps including a template file in the the agent distro. Sorry for that @jbeker!

@jbeker
Copy link
Author

jbeker commented Feb 16, 2018

That would be amazing! Thanks.

@harrietgrace
Copy link
Contributor

Looks like the syntax for this was updated June '18. @lox was there ever a template added to the ubuntu agent distro?

@toolmantim
Copy link
Contributor

Because we don't have a template in the Ubuntu distro yet, we'll need to update those parallel instructions to be:

# Stop and disable the default buildkite-agent service
sudo systemctl stop buildkite-agent && sudo systemctl disable buildkite-agent

# Create a systemd template
sudo cp /lib/systemd/system/buildkite-agent.service /etc/systemd/system/buildkite-agent@.service

# Start five agents using the systemd template we created above
sudo systemctl enable --now buildkite-agent@1
sudo systemctl enable --now buildkite-agent@2
sudo systemctl enable --now buildkite-agent@3
sudo systemctl enable --now buildkite-agent@4
sudo systemctl enable --now buildkite-agent@5

If we included a template in the Ubuntu distro, then we could simplify it down to:

# Stop and disable the default buildkite-agent service
sudo systemctl stop buildkite-agent && sudo systemctl disable buildkite-agent

# Start five agents using the systemd template we created above
sudo systemctl enable --now buildkite-agent@1
sudo systemctl enable --now buildkite-agent@2
sudo systemctl enable --now buildkite-agent@3
sudo systemctl enable --now buildkite-agent@4
sudo systemctl enable --now buildkite-agent@5

@harrietgrace could you open an issue on https://github.com/buildkite/agent to add a template file to any distros that use systemd?

For now though, we can probably just go with that first one?

@harrietgrace harrietgrace added the in progress Issues that have a fix/update in the works label Mar 25, 2019
@harrietgrace harrietgrace removed the in progress Issues that have a fix/update in the works label Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants