New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade most of gems #742
Upgrade most of gems #742
Conversation
Upgrade all of the things! My personal preference is to upgrade gems in smaller batches over multiple PRs, so testing each PR is easier and any surprises are easier to track down. This is a pretty simple app though, so maybe we can get away with all-at-once? |
We can turn on dependantbot and configure it in a less noisy way.
The tests passed and clicking through the reviews app everything looks okay. |
I'm 👍 on dependabot ongoing. I've clicked around the review app and looks fine. Thanks for diving in @JuanitoFatas . |
1b8e204
to
689901d
Compare
app/models/page.rb
Outdated
av.render(*args) | ||
ActionController::Base.append_view_path "app/views/pages" | ||
renderer = ActionController::Base.renderer.new | ||
renderer.render(partial: args.first) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matthewd What do you think about the change here? 🙇♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first line is mutating a global value, but this method gets called multiple times.
Sounds to me like the append_view_path
should be in PagesController
, then this would be:
def render(partial)
PagesController.render(partial: partial)
end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Fixed in 4488f93.
* Rails 6 * Lock rouge because syntax highlight changed * Use ActionController::Base renderer
689901d
to
4488f93
Compare
Co-Authored-By: Matthew Draper <matthew@trebex.net>
4488f93
to
4365e28
Compare
This PR:
Page#render