Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Optimising for slow Docker builds #1092

Open
benschwarz opened this issue May 24, 2018 · 5 comments · Fixed by #1281
Open

[Docs] Optimising for slow Docker builds #1092

benschwarz opened this issue May 24, 2018 · 5 comments · Fixed by #1281
Assignees

Comments

@benschwarz
Copy link
Contributor

The "Optimising for slow docker Docker builds" found on the readme for this repo is really useful, but rather hidden on the elastic stack readme. (If someone uses docker, but not the elastic stack, they'd have a hard time finding this information).

I think it'd be super useful to move that content to a docs page of its own at Buildkite.com.

Additionally, I was wondering if you'd be able to clarify some of the points:

Update the pipeline’s env hook in your secrets bucket to perform a docker login

pipeline's env hook could maybe be a reference to something else in docs? I read it three times and I'm still not 100% sure what I'm looking for.

"secrets bucket" could also maybe be a link to higher up in the readme: "Build secrets". (and rename it to read 'build secrets bucket').

@lox
Copy link
Contributor

lox commented Jul 28, 2019

@harrietgrace thoughts on where we should move this? I'm thinking perhaps in https://buildkite.com/docs/tutorials/elastic-ci-stack-aws? Alternately we could put it in https://buildkite.com/docs/tutorials/docker-containerized-builds.

@harrietgrace
Copy link
Contributor

@lox I think in the Docker Containerized Builds docs for now - the Elastic Stack doc is too high level and getting-started-y for this section to fit in there.

It would be great to revise that Elastic stack doc sometime too... it could be so much more awesome than it currently is!

@keithduncan keithduncan transferred this issue from buildkite/elastic-ci-stack-for-aws Jul 5, 2021
@plaindocs
Copy link
Contributor

This is in the docs site now, and I've added a quick link to the environment hook.

Thanks!

@plaindocs plaindocs linked a pull request Nov 26, 2021 that will close this issue
@benschwarz
Copy link
Contributor Author

Thanks for the update @plaindocs. I find this point particularly difficult to parse:

Update the pipeline’s environment hook in your secrets bucket to perform a docker login

I know what you're suggesting in practice, but there's 3 instructions in one sentence and it may be difficult for Buildkite newcomers. Maybe a more detailed example would be helpful?

@plaindocs
Copy link
Contributor

Thanks @benschwarz , I'll take another look and break it down. 👍

@plaindocs plaindocs reopened this Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants