Pull docker image used for qemu binfmt in packer #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
triarius
commented
Jun 20, 2023
| # See https://docs.docker.com/build/building/multi-platform/ | ||
| QEMU_BINFMT_VERSION=7.0.0-28 | ||
| sudo mkdir -p /usr/local/lib | ||
| echo "QEMU_BINFMT_VERSION=${QEMU_BINFMT_VERSION}" | sudo tee -a /usr/local/lib/bk-install-elastic-stack.sh |
There was a problem hiding this comment.
We do this so that the version that is pulled is later run.
triarius
force-pushed
the
pdp-1146-pull-docker-images-in-packer-instead-of-startup
branch
from
be95146
to
71f79a0
Compare
triarius
deleted the
pdp-1146-pull-docker-images-in-packer-instead-of-startup
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a method documented by docker to install some tools necessary for building (and running) multiarch docker images. See https://docs.docker.com/build/building/multi-platform/
Previously we did this entirely in the startup script
packer/linux/scripts/install-docker.sh. However, as was revealed in dogfooding, launching many instances at the same time could cause the startup script to fail due to docker hub rate limits. Instead, we can pull the image when the AMI is being built by packer, and then run the installation in the startup script.Why not pull and run when building the AMI? Running multiarch images in CI failed when I tried to do that: https://buildkite.com/buildkite-aws-stack/buildkite-aws-stack/builds/3275