Fix qemu binfmt image is pulled during instance startup #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should have been pulled when the AMI is built.
…we source the lib file
When you pull an image from a registry and specify both a tag and a digest, docker does not seem to tag it locally. This leaves the image unable to be run if both the tag and the digest are specified to `docker run`. But it will run if only by the digest is specified.
triarius
changed the base branch from
main
to
pdp-1587-clearer-logs-in-buildkiteelastic-stack-log-group
triarius
commented
Oct 3, 2023
| sudo mkdir -p /usr/local/lib | ||
| echo "QEMU_BINFMT_TAG=\"$QEMU_BINFMT_TAG\"" | sudo tee -a /usr/local/lib/bk-configure-docker.sh |
There was a problem hiding this comment.
When images are pulled with a tag and digest, docker does not seem to keep the tag. Try it with
$ docker pull alpine:3.18.4@sha256:eece025e432126ce23f223450a0326fbebde39cdf496a85d8c016293fc851978
$ docker image ls
REPOSITORY TAG IMAGE ID CREATED SIZE
alpine <none> 8ca4688f4f35 4 days ago 7.33MB
I don't think it affects docker run though 🤷♂️.
triarius
commented
Oct 3, 2023
Base automatically changed from
pdp-1587-clearer-logs-in-buildkiteelastic-stack-log-group
to
main
October 4, 2023 00:04
triarius
deleted the
pdp-1788-fix-qemu-binfmt-image-is-pulled-during-elastic-ci-stack
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention was always for it to be pulled when the AMI is built, and just run when then instance is started, but it turns out the garbage collector was running before the docker setup script, so the image was being pulled on every instance start.
This PR fixes this by only enabling the timers after docker has been configured and the qemu binfmt image has run.
I've also added more comments around the mechanism by which the digest of the qemu binfmt image is passed from the packer build scripts to the startup script, as it was the source of some confusion. As well as more logging in general.
Closes: #1229