Added BuildkiteAgentCancelGracePeriod option to linux stack #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgrisafi
force-pushed
the
configurable-cancel-grace-period
branch
from
b8d1ca7
to
38f7a7e
Compare
moskyb
force-pushed
the
configurable-cancel-grace-period
branch
from
a084bff
to
054fec6
Compare
DrJosh9000
approved these changes
Nov 7, 2023
|
@njgrisafi i've done a wee bit of massaging + rebasing on this PR - just fixing a typo. thanks for your contribution! |
|
worth noting: there's a difference between the windows and linux stacks here; linux stacks were defaulting to 60s for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following expectations from docs here https://buildkite.com/docs/agent/v3/configuration
We should allow users to configure the cancellation grace period.
Added
aws-stack.yml(default 60)