Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launch elastic test elastic stacks using templates from S3 #1267

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Launch elastic test elastic stacks using templates from S3 #1267

merged 1 commit into from
Dec 7, 2023

Conversation

moskyb
Copy link
Contributor

@moskyb moskyb commented Dec 6, 2023

We were previously using templates as a cli param, but there's a 51KB limit on that, which we've recently hit

@moskyb
Launch elastic test elastic stacks using templates from S3
998376f 
We were previously using templates as a cli param, but there's a 51KB limit on that, which we've recently hit
@moskyb moskyb requested a review from a team December 6, 2023 05:20
triarius
triarius approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@triarius triarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking it out of your other PR 💜

@moskyb moskyb merged commit 7a19149 into main Dec 7, 2023
1 check passed
@moskyb moskyb deleted the test-templates-from-s3 branch December 7, 2023 00:23
@triarius triarius mentioned this pull request Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@triarius triarius triarius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@moskyb @triarius