Optimize the permissions check script to only fix the current pipeline’s build dir #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toolmantim
force-pushed
the
only-fix-permissions-on-the-build-dir
branch
from
57c26d6
to
7992501
Compare
|
Looks legit to me! I wish I could remember why we didn't do this in the first place. |
lox
approved these changes
Sep 8, 2017
toolmantim
force-pushed
the
only-fix-permissions-on-the-build-dir
branch
2 times, most recently
from
5428dc8
to
9c21039
Compare
Currently the fix-buildkite-agent-builds-permissions script, that's run by our environment hook, chown's the agent’s entire builds directory on every job run. This means the chown operation gets slower every time a different pipeline is checked out onto disk. This changes the permissions fixing script to chown only the running pipeline’s checkout dir (if it exists), rather than the entire builds dir. The permissions tests have also been moved from the comment in the bottom of the file into their own executable .bats tests.
toolmantim
force-pushed
the
only-fix-permissions-on-the-build-dir
branch
from
9c21039
to
03c6d98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the fix-buildkite-agent-builds-permissions script, that's run by our environment hook,
chown's the agent’s entire builds directory on every job run. This means the chown operation gets slower every time a different pipeline is checked out onto disk.This PR changes the permissions fixing script to
chownonly the running pipeline’s checkout dir (if it exists), rather than the entire builds dir. The permissions tests have also been moved from the comment in the bottom of the file into their own executable.batstests.