Use new Metrics API, drop requirement for org-slug and api-token 馃帀 #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huzzah!! |
|
Yep, looks about right to me. Can we ship this to our own stack as a test? Or just |
?
sj26
approved these changes
Apr 17, 2018
|
It's been running on our elastic stacks all today @sj26. Moving to master and doing some more testing. |
|
馃憦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the new private elastic stack metrics API that @sj26 created we can drop the requirement for a personal access token, allowing just an agent registration token.
Hoping this will be a big win for teams that have to manage lots of personal access tokens just for elastic stacks.