Set correct variable to pass to upstream ecr plugin #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the variable exported after reading
AWS_ECR_LOGIN_REGISTRY_IDSisn't correct to configure the ecr login plugin. We're currently getting around this by explicitly settingBUILDKITE_PLUGIN_ECR_ACCOUNT_IDS_0in our stack, but thought it was worth trying to get fixed to configure this the documented way.https://github.com/buildkite-plugins/ecr-buildkite-plugin/blob/3068b26de2eb43b8ae6ebf081b1f0626d018d8c0/hooks/pre-command#L58
Thanks!