Update ArtifactBucketPolicy to match docs #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It may also be wise to update the documentation to take into account that AWS accounts can now have global S3 public access restrictions which cause a 403 regardless of the IAM permissions and you need to turn on the private ACL. |
|
Thanks for this @gough! Worth noting, I don't think we actually set |
|
Let's get this merged and then look at the follow on changes. |
|
Can confirm this @lox. |
|
Actually digging into this more, the end point (for example, bucket) and the path are not separate for BK. It would be nice for an agent environment hook to set an ENV, such as |
lox
added a commit
that referenced
this pull request
Nov 4, 2019
Update ArtifactBucketPolicy to match docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the policy to match what is suggested in the documentation (linked below).
In our testing, the default policy also did not allow uploading of artifacts despite what the policy seemed to allow. However, this could be due to another issue in our configuration.
https://buildkite.com/docs/agent/v3/cli-artifact#using-your-own-private-aws-s3-bucket