Ensure powershell scripts fail when executable fails #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have to explicitly test the exit status after running executables because powershell doesn't automatically fail when an executable's exit status is non-zero. Signed-off-by: Jeremiah Snapp <jeremiah@chef.io>
|
Ugh, so gross 😢 Are you sure there isn't an alternative? |
|
Other than not use Powershell? Not that we've found. We got this guidance from a "Windows expert" (for whatever that's worth). But, for context, think of Powershell as a programming language, not a scripting one. Like golang, you gotta tell it when to exit, and with what error code. |
|
At least here we don't have to handle |
|
Cool, let's merge this in. Is what it is! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to explicitly test the exit status after running executables because powershell doesn't automatically fail when an executable's exit status is non-zero.
We've deployed these changes to our own Windows Buildkite packer template and it really increases the confidence that the powershell scripts haven't silently failed.