Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update agent config: tags-from-ec2 -> tags-from-ec2-meta-data #727

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

yob
Copy link
Contributor

@yob yob commented Oct 1, 2020

I've noticed the following warning in log output of various stacks:

The config option tags-from-ec2 has been renamed to tags-from-ec2-meta-data. Please update your configuration.

The deprecation happened in agent 3.17.0 (august 2019) [1]. The stack ships with a more recent version and it seems unlikely anyone will jump through hoops to downgrade, so I think it's safe to use the newer flag.

I've noticed the following warning in log output of various stacks:

> The config option `tags-from-ec2` has been renamed to `tags-from-ec2-meta-data`. Please update your configuration.

The deprecation happened in agent 3.17.0 (august 2019) [1]. The stack
ships with a more recent version and it seems unlikely anyone will jump
through hoops to downgrade, so I think it's safe to use the newer flag.

[1] buildkite/agent#1067
@yob yob requested a review from a team October 1, 2020 13:58
Copy link
Member

@JuanitoFatas JuanitoFatas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 Thanks for updating this!

@yob yob merged commit c3db2b9 into master Oct 2, 2020
@yob yob deleted the update-agent-flag branch October 2, 2020 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants