Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session manager plugin #818

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Conversation

nitrocode
Copy link
Contributor

Closes #817

Not sure how to install the executable silently on Windows.

@yob
Copy link
Contributor

yob commented Mar 25, 2021

I've run a build and confirmed this works as expected.

is it possible to rebase onto master (to get #819) and remove the merge commits?

@yob
Copy link
Contributor

yob commented Mar 25, 2021

One thing I haven't done is actually test the plugin works. We don't really use SSM yet though, so that test wouldn't be straight forward. Have you been able to run a build with one of these AMIs and confirm the plugin works as intended?

@nitrocode
Copy link
Contributor Author

I've run a build and confirmed this works as expected.

Perfect.

is it possible to rebase onto master (to get #819) and remove the merge commits?

Done.

One thing I haven't done is actually test the plugin works. We don't really use SSM yet though, so that test wouldn't be straight forward. Have you been able to run a build with one of these AMIs and confirm the plugin works as intended?

I did not build an AMI but I did run the script on an x86 and an arm machine to make sure it installs correctly. Then I gave the iam role of my instance access to ssm:StartSession across * resources. Finally, I ran this command from the buildkite ec2 instance where I installed the session-manager-plugin and it worked as expected.

$ aws --region us-west-2 ssm start-session --target i-snip

Starting session with SessionId:

@yob yob merged commit 083f89d into buildkite:master Mar 25, 2021
@yob
Copy link
Contributor

yob commented Mar 25, 2021

Lovely, thanks!

@nitrocode nitrocode deleted the session-manager-plugin branch March 25, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow buildkite to use ssm to run commands into another instance with session-manager-plugin
2 participants