Create secrets bucket only when needed #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We would like to avoid managed secret buckets creation in case of "EnableSecretsPlugin = false"
yob
reviewed
May 16, 2021
There was a problem hiding this comment.
Confirming I understand the motivation here: Currently we will create a secrets bucket if the SecretsBucket param is blank, and it's blank by default. All stacks that don't provide a customer SecretsBucket will have a new bucket created, even if they've disabled the secrets plugin.
With this change, we'll skip creating the bucket if EnableSecretsBucket is false - regardless of what SecretsBucket is set to.
|
Hi @yob, exactly as you described. |
yob
approved these changes
May 17, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to avoid managed secret buckets creation in case of
EnableSecretsPlugin = false