Changes for v3.8.0 #106
Merged
Changes for v3.8.0 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than dropping some HTML-sensitive characters during parsing of element attibute values, instead thoroughly HTML-escape these attributes during rendering when interpolating them into actual HTML. The element attribute parser now supports single quotes within double-quoted attributes, and double quotes within single-quoted attributes. I don't know if that's useful, but it seems more correct and less surprising then dropping them. Substantially more test coverage for handling and producing HTML.
An allow-list would be preferable, but we don't know what URL schemes are being legitimately used in the wild, so that would be a breaking change, and likely require configurability.
Rather than dropping some HTML-sensitive characters during parsing of element attibute values, instead thoroughly HTML-escape these attributes during rendering when interpolating them into actual HTML. The element attribute parser now supports single quotes within double-quoted attributes, and double quotes within single-quoted attributes. I don't know if that's useful, but it seems more correct and less surprising then dropping them. Substantially more test coverage for handling and producing HTML.
`e` feels more like `err`, while `h` matches Rails: https://api.rubyonrails.org/classes/ERB/Util.html#method-c-h
I've preserved the nature of the file being gzipped and committed the gzipped file to the repo. It can be created from its source with `go generate ./...`, but the standard practice is to commit files generated by `go generate` so that a `go install` command is able to use them.
Instead, in server mode, return appropriate http status codes and in file/stdin mode, exit status 1.
This avoids `go generate` making the build process slightly more complex, and avoids committing an (admittedly tiny) gzipped file.
# Conflicts: # element.go # element_test.go # terminal_test.go
…g-unsafepointer' # Conflicts: # Dockerfile # go.mod
pda
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.