Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload zip artifacts #123

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Upload zip artifacts #123

merged 1 commit into from
Dec 7, 2023

Conversation

DrJosh9000
Copy link
Contributor

@DrJosh9000 DrJosh9000 commented Dec 7, 2023

I noticed that we build zip files with Windows binaries, but never save them as artifacts.

This also bumps docker-compose plugin to v4.16.0 (number is bigger you see)

@DrJosh9000 DrJosh9000 requested a review from a team December 7, 2023 06:04
Copy link
Contributor

@triarius triarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

run: terminal

- wait
- name: ":neckbeard: Benchmark"
command: make bench
plugins:
docker-compose#v1.7.0:
docker-compose#v4.16.0:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's a huge bump 📈

@DrJosh9000 DrJosh9000 merged commit 470ffd4 into main Dec 7, 2023
1 check passed
@DrJosh9000 DrJosh9000 deleted the upload-zips branch December 7, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants