Update the paths where we load environment variables from #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For consistency with other pipelines, we're prefixing all ENV var paths with the org slug in addition to the pipeline slug - note the `/buildkite` inserted into each path here.
mcncl
approved these changes
Apr 28, 2023
jradtilbrook
approved these changes
Apr 28, 2023
There was a problem hiding this comment.
Looks good 👍
But either the vars don't exist at the new paths yet or the IAM role is not allowed to read from that path (or maybe both).
That shouldn't require a change to this PR though so approving this now assuming it will be fixed and the build re-run to get to green before merging
|
Oh yes I see the PR to fix IAM now 👍 |
|
Sorry, I could've got the sequencing a little smoother 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency with other pipelines, we're prefixing all ENV var paths with the org slug in addition to the pipeline slug - note the
/buildkiteinserted into each path here.