Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Computed values from Pipeline where not required #275

Merged
merged 2 commits into from
May 26, 2023

Conversation

mcncl
Copy link
Contributor

@mcncl mcncl commented May 26, 2023

Problem

Setting a Default value of nil on the schema will inherit the nil value of its type; default_timeout_in_minutes, for example, will be set as 0 which will cause a command to never timeout (it's the same as setting no timeout).

Solution

Setting int values to a sensible default (the one shown in the docs) when values are not defined by the user.

Additional

We have a number of fields set as Computed which need not be; a computed value is one that the user will likely never interact with.

@mcncl mcncl requested a review from jradtilbrook May 26, 2023 01:12
@mcncl mcncl merged commit 5ba55a5 into main May 26, 2023
1 check passed
@mcncl mcncl deleted the remove_unnecessary_computeds branch May 26, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants