Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues when bumping genqlient from 0.4.0 to 0.6.0 #278

Merged
merged 4 commits into from
May 30, 2023

Conversation

lizrabuya
Copy link
Contributor

The dependabot generated PR #270 had issues as genqlient 0.6.0 was no longer compatible with the generated functions.

To fix this:

  • updated generated.go with the new function signatures (run make generate)
  • updated go packages

dependabot bot and others added 3 commits May 26, 2023 00:33
Bumps [github.com/Khan/genqlient](https://github.com/Khan/genqlient) from 0.4.0 to 0.6.0.
- [Release notes](https://github.com/Khan/genqlient/releases)
- [Changelog](https://github.com/Khan/genqlient/blob/main/docs/CHANGELOG.md)
- [Commits](Khan/genqlient@v0.4.0...v0.6.0)

---
updated-dependencies:
- dependency-name: github.com/Khan/genqlient
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Copy link
Contributor

@mcncl mcncl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nice work on getting the upgrade working! Feel free to merge this in and we can look at doing a release tomorrow. 🚀

Copy link
Contributor

@james2791 james2791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪
New fns look easier to digest

@lizrabuya lizrabuya merged commit 523788a into main May 30, 2023
1 check passed
@lizrabuya lizrabuya deleted the lzr/dependabot-pr-fixes branch May 30, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants