New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SUP-1068 Migrate pipeline resource to framework #345
SUP-1068 Migrate pipeline resource to framework #345
Conversation
@@ -105,7 +105,7 @@ func TestAccPipeline_add_remove_withcluster(t *testing.T) { | |||
testAccCheckPipelineRemoteValues(&resourcePipeline, "Test Pipeline foo"), | |||
// Confirm the pipeline has the correct values in terraform state | |||
resource.TestCheckResourceAttr("buildkite_pipeline.foobar", "name", "Test Pipeline foo"), | |||
resource.TestCheckResourceAttr("buildkite_pipeline.foobar", "cluster_id", ""), | |||
resource.TestCheckNoResourceAttr("buildkite_pipeline.foobar", "cluster_id"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The resource now sets this as null instead of an empty string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting testAccPipelineConfigBasicWithTeam("foo")
clears the cluster ID off the pipeline - and new impl sets it as null - this LG
Alright I think this is ready for review again. With framework, when defining a block attribute you cannot set it as required or a default value. And the framework also performs validation on the state. This causes trouble for the I think long-term, moving to protocol v6 and converting it to a nested attribute is the way to go |
@jradtilbrook I think maybe we let Pagerduty know they need to look at updating sooner rather than later? |
@mcncl yeah I think so. The good news is that the latest release has basically all the new features we were aiming for for v1. Its just some bug fixes from here. So if they can pin their version now, they won't really miss out on anything (especially if they haven't hit the cases for the bugs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is at a point of rolling-in, LGTM 👍
PR checklist:
docs/
updatedexamples/
(useful to demo new field/resource)CHANGELOG.md
updated with pending release informationTheres a few things I want to test manually