Add acceptance tests for the agent_token resource #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the first acceptance tests for the provider, so they come with
a bunch of supporting infrastructure:
* a new Make target
* Some instructions in the README
* a new pipeline step that can only run on the main branch
* if a third party PR removes this restriction, the step will run but
fail because it'll run on an agent with no access to the required
credentials in SSM ParameterStore
The CI setup here is imperfect. Pull requests won't run the acceptance
tests and there's a risk we'll only notice a failure in the acceptance
tests after merging. For now we'll have to live with that (maybe by
manually running the tests ourselves prior to merging?) while we discuss
a better approach.
yob
force-pushed
the
acceptance-test-agent-tokens
branch
from
07156db
to
719bc2e
Compare
4 tasks
|
The following pages were useful resources while I worked on this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the first acceptance tests for the provider, so they come with a bunch of supporting infrastructure:
The CI setup here is imperfect. Pull requests won't run the acceptance tests and there's a risk we'll only notice a failure in the acceptance tests after merging. For now we'll have to live with that (maybe by manually running the tests ourselves prior to merging?) while we discuss a better approach.