Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file path and location support, update swift to 5.7 #61

Merged
merged 10 commits into from Apr 9, 2024

Conversation

DechengMa
Copy link
Collaborator

@DechengMa DechengMa commented Feb 14, 2024

💬 Summary of Changes

🧾 Checklist

  • 🧐 Performed a self-review of the changes
  • ✅ Added tests to cover changes
  • 🏎 Ran Unit Tests and they all passed
  • 🏷 Labeled this PR appropriately

📝 Items of Note

@DechengMa DechengMa force-pushed the update-swift-add-location branch 4 times, most recently from 7ab2049 to 2313053 Compare February 15, 2024 03:20
@DechengMa DechengMa added the enhancement New feature or request label Feb 15, 2024
@DechengMa DechengMa self-assigned this Feb 15, 2024
@DechengMa DechengMa marked this pull request as ready for review February 15, 2024 22:28
@DechengMa DechengMa requested a review from a team as a code owner February 15, 2024 22:28
@DechengMa DechengMa changed the title Add file path and location support, update swift to 5.7. Bump up version to 0.4.1 Add file path and location support, update swift to 5.7 Feb 16, 2024
@DechengMa
Copy link
Collaborator Author

The BK runner pipeline hasn't been set up properly yet so failing now

Copy link

@gchan gchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

@DechengMa DechengMa merged commit 631a240 into main Apr 9, 2024
5 checks passed
@DechengMa DechengMa deleted the update-swift-add-location branch April 9, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants