New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file path and location support, update swift to 5.7 #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DechengMa
force-pushed
the
update-swift-add-location
branch
4 times, most recently
from
February 15, 2024 03:20
7ab2049
to
2313053
Compare
DechengMa
changed the title
Add file path and location support, update swift to 5.7. Bump up version to 0.4.1
Add file path and location support, update swift to 5.7
Feb 16, 2024
The BK runner pipeline hasn't been set up properly yet so failing now |
DechengMa
force-pushed
the
update-swift-add-location
branch
from
March 5, 2024 02:24
2313053
to
014047b
Compare
DechengMa
force-pushed
the
update-swift-add-location
branch
from
March 5, 2024 02:42
044ad38
to
8ef4c0a
Compare
JamesW-iOS
approved these changes
Apr 8, 2024
gchan
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💬 Summary of Changes
Add files path and location support for failure tests (partially address Include
location
andfileName
with uploadedTrace
#8)Update Swift version to 5.7
Bump up package versions to 0.4.1
🧾 Checklist
📝 Items of Note