This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
#24: remove dependency on buildo-state/connect (do not connect() internally) (closes #24) #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giogonzo
force-pushed
the
24-remove_dependency_on_buildostateconnect
branch
from
d750e5b
to
9ddfdba
Compare
FrancescoCioria
approved these changes
Feb 4, 2017
|
|
||
| static displayName = displayName; | ||
| static displayName = displayName; |
There was a problem hiding this comment.
why isn't this static displayName = displayName('queries')(Component); as done in CommandWrapper?
There was a problem hiding this comment.
just because displayName is precomputed above and reused a few other times for warnings
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #24
Test Plan
tested along with the new versions of
react-containerandweb-sharedon qia 👍