Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

#29: use Query.upsetParams and Command.invalidateParams to produce InputType (closes #29) #30

Merged
merged 2 commits into from
Feb 21, 2017
Merged

#29: use Query.upsetParams and Command.invalidateParams to produce InputType (closes #29) #30

merged 2 commits into from
Feb 21, 2017

Conversation

giogonzo
Copy link
Member

@giogonzo giogonzo commented Feb 20, 2017 •
edited
Loading

Issue #29

Test Plan

tests performed

tested manually on gdsm and qia

tests not performed (domain coverage)

At times not everything can be tested, and writing what hasn't been tested is just as important as writing what has been tested.

An example of partial test is a field displaying 4 possible values. If 3 values are tested, with screenshots, and 1 is not, then it should be mentioned here.}

@nemobot nemobot added the WIP label Feb 20, 2017
@nemobot nemobot added in review and removed WIP labels Feb 20, 2017
@FrancescoCioria FrancescoCioria merged commit da5347e into master Feb 21, 2017
@nemobot
Copy link

nemobot commented Feb 21, 2017

@FrancescoCioria FrancescoCioria deleted the 29-use_queryupsetparams_and_commandinvalidateparams branch February 21, 2017 15:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FrancescoCioria FrancescoCioria FrancescoCioria approved these changes

Assignees
No one assigned
Labels
waiting for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@giogonzo @nemobot @FrancescoCioria