Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

declareQueries should not accept queries returning undefined (closes #54) #53

Merged
merged 1 commit into from
Mar 21, 2018

Conversation

giogonzo
Copy link
Member

@giogonzo giogonzo commented Mar 20, 2018

tests performed

declaring a query that resolves to undefined yields:

      TS2345: Argument of type '{ a: QueryReturn<IOTSDictToType<{}> & IOTSDictToType<{}> & IOTSDictToType<{}>,...' is not assignable to parameter of type 'Queries'.
  Property 'a' is incompatible with index signature.
    Type 'QueryReturn<IOTSDictToType<{}> & IOTSDictToType<{}> & IOTSDictToType<{}>, T[] | undefined>' is not assignable to type 'QueryReturn<any, mixed>'.
      Type 'T[] | undefined' is not assignable to type 'mixed'.
        Type 'undefined' is not assignable to type 'mixed'.

@nemobot nemobot added the WIP label Mar 20, 2018
@nemobot nemobot added in review and removed WIP labels Mar 20, 2018
@giogonzo giogonzo changed the title declareQueries should not accept queries returning undefined declareQueries should not accept queries returning undefined (closes #54) Mar 20, 2018
@ecamellini ecamellini merged commit ffe3a84 into master Mar 21, 2018
@nemobot
Copy link

nemobot commented Mar 21, 2018

@ecamellini ecamellini deleted the giogonzo-patch-1 branch March 21, 2018 11:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants