add basic CI actions #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianMitchL
reviewed
May 29, 2020
.github/workflows/main.yml
Outdated
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-node@v1 | ||
| - run: npm install --no-package-lock |
There was a problem hiding this comment.
How about we start committing the package-lock.json file instead of skipping it? Are there reasons it's being ignored today?
There was a problem hiding this comment.
We could use npm ci for a faster and clean install reading off of just the package-lock.json file too.
There was a problem hiding this comment.
Are there reasons it's being ignored today?
Not really, It's just what I've been used to for libraries up to now. But let's add it. I will also use npm ci
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.